Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for nc.LinearBiasSystematic #467

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

marcpaterno
Copy link
Collaborator

@marcpaterno marcpaterno commented Oct 31, 2024

Description

This PR introduces additional testing to cover previously untested code.

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Refactoring

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno marked this pull request as ready for review October 31, 2024 16:43
@marcpaterno marcpaterno marked this pull request as draft October 31, 2024 16:44
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (1d8494a) to head (294f0fc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #467     +/-   ##
========================================
+ Coverage    99.0%   99.2%   +0.1%     
========================================
  Files          54      54             
  Lines        4147    4149      +2     
========================================
+ Hits         4107    4117     +10     
+ Misses         40      32      -8     
Files with missing lines Coverage Δ
firecrown/parameters.py 100.0% <100.0%> (+0.6%) ⬆️

... and 1 file with indirect coverage changes

@marcpaterno marcpaterno marked this pull request as ready for review October 31, 2024 22:03
@marcpaterno marcpaterno requested a review from vitenti October 31, 2024 22:03
@marcpaterno marcpaterno merged commit 15b878d into master Nov 1, 2024
9 checks passed
@marcpaterno marcpaterno deleted the improve_test_coverage branch November 1, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants