Package Updates #301
Merged
Package Updates #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove "pkg" dependency as this seems to no longer be necessary - add explicit dependencies on react and its @types
- necessary for supporting node v20
|
@hextraza and @EthanD1998: can we discuss this tomorrow? |
@bbimber Thanks for taking a look. Things are looking good in CI so I'm prepared to merge soon. Please provide feedback and/or approval when you have a moment. |
bbimber
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
@labkey-nicka: if CI is passing I'm not that concerned. we will take a closer look, but go ahead and merge if you need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This updates the jbrowse module to run on Node v20.
Related Pull Requests
Changes
@labkey/componentsas it is not used.reactandreact-domso it is declared by the package rather than leaving it up to node/npm to decide which version to use.pkg(dead/archived) dependency with@yao-pkg/pkgforked version. This supports binaries being built on Node 20+.react-hot-loaderto usewebpack serve.@types/reactpackage. Fixed by adding "overrides" into the package.json.