Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clinical ETL and misc updates #409

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Clinical ETL and misc updates #409

merged 10 commits into from
Oct 7, 2024

Conversation

labkey-martyp
Copy link
Contributor

@labkey-martyp labkey-martyp commented Oct 6, 2024 •
edited
Loading

Rationale

Updates and refactors to some ETLs and misc updates to match workflows and data.

Changes

  • Refactor alopecia ETL and report using clinical_observations
  • Trim some more names in ETLs
  • Add SOAP to clinremarks report
  • Close more records on death/departure
  • End date option for obs orders
  • Fix duplicate issue in obs schedule
  • isActive col updates
  • Update script to ensure data loaded

@labkey-martyp labkey-martyp linked an issue Oct 7, 2024 that may be closed by this pull request
[NIRC] Clinical ETL and misc updates #410
Open
8 tasks
ankurjuneja
ankurjuneja approved these changes Oct 7, 2024
View reviewed changes
nirc_ehr/resources/queries/study/clinical_observationsSummary.sql
scheduledDate,
QCState
FROM clinical_observations
GROUP BY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need an aggregate column for the group by?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is just to not show duplicates. No aggregate necessary

@labkey-martyp labkey-martyp merged commit 119a81a into release24.7-SNAPSHOT Oct 7, 2024
3 checks passed
@labkey-martyp labkey-martyp deleted the 24.7_fb_clinical_fixes branch October 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurjuneja ankurjuneja ankurjuneja approved these changes

@labkey-bpatel labkey-bpatel Awaiting requested review from labkey-bpatel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NIRC] Clinical ETL and misc updates
2 participants
@labkey-martyp @ankurjuneja