-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional context paths #5156
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// | ||
// Source code recreated from a .class file by IntelliJ IDEA | ||
// (powered by FernFlower decompiler) | ||
// | ||
|
||
package org.labkey.api.view; | ||
|
||
import java.io.IOException; | ||
|
||
import jakarta.servlet.ServletException; | ||
import jakarta.servlet.http.HttpServlet; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
|
||
/** Simple redirector to redirect and forward from legacy context paths to the root context */ | ||
public class RedirectorServlet extends HttpServlet | ||
{ | ||
private final String _legacyContextPath; | ||
|
||
public RedirectorServlet(String legacyContextPath) | ||
{ | ||
if (!legacyContextPath.startsWith("/") || legacyContextPath.length() < 2) | ||
{ | ||
throw new IllegalArgumentException("Invalid legacy context path: " + legacyContextPath); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this error message use the property name to make it easier to track down where the error is? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated. |
||
} | ||
_legacyContextPath = legacyContextPath; | ||
} | ||
|
||
@Override | ||
protected void service(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException | ||
{ | ||
|
||
if ("get".equalsIgnoreCase(request.getMethod())) | ||
{ | ||
// Send a redirect to let the client know there's a new preferred URL | ||
String originalUrl = request.getRequestURL().toString(); | ||
String redirectUrl = originalUrl.replaceFirst(_legacyContextPath, ""); | ||
labkey-susanh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
response.setStatus(HttpServletResponse.SC_MOVED_PERMANENTLY); | ||
response.setHeader("Location", redirectUrl); | ||
} | ||
else | ||
{ | ||
// For non-GETs, use a forward so that we don't lose POST parameters, etc | ||
String originalUri = request.getRequestURI(); | ||
String forwardUri = originalUri.replaceFirst(_legacyContextPath, ""); | ||
|
||
getServletContext().getRequestDispatcher(forwardUri).forward(request, response); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, IntelliJ had helpfully collapsed this section so I hadn't noticed it. I started with a redirector servlet that I wrote many years ago but I think the source code got lost in the SVN->GitHub migration. I still had the binaries in email though.