Support additional context paths #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directing, and for secondary static content
labkey-susanh
approved these changes
Jan 24, 2024
| @@ -156,7 +162,7 @@ protected TomcatWebServer getTomcatWebServer(Tomcat tomcat) | |||
| } | |||
|
|
|||
| // set the root path to the context explicitly | |||
| context.setPath(""); | |||
| context.setPath(contextProperties.getContextPath()); | |||
There was a problem hiding this comment.
Any need to do trimming on this value and the legacyContextPath value? Perhaps in the setter?
There was a problem hiding this comment.
That would be fine to do, but we don't trim any of the other properties so I'm inclined to leave as-is. From a quick test, the properties file parser automatically trims leading spaces for the value (after the =) but not trailing spaces.
Co-authored-by: Susan Hert <susanh@labkey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some server configurations have historically used non-root context paths, and/or deployed additional web apps for delivering static content.
Changes
context.contextPathcontext.legacyContextPathwebapps.contextPathandwebapps.docBase