Bump Spring framework's version #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good, presuming the OWASP check passes
https://teamcity.labkey.org/buildConfiguration/LabKey_2311Release_Internal_InternalSuites_OwaspDependencyCheck/2934542
server/embedded/build.gradle
Outdated
| @@ -59,6 +59,48 @@ dependencies { | |||
| } | |||
| } | |||
|
|
|||
| // TODO these shouldn't be merged forward | |||
There was a problem hiding this comment.
Why should this not be merged forward?
There was a problem hiding this comment.
The force statements aren't needed with the spring-boot version used in develop, AFICT. Also, going forward as we move towards Embbedded do want to keep the standalone Spring version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=49820 Force the spring version
Related Pull Requests
Changes