Fix startup errors with embedded Tomcat deployments #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-stuartm
approved these changes
Mar 15, 2024
labkey-tchad
changed the title
labkey-jeckels
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some of our deployment scripts rename the
labkeyServer.jar. We can be less restrictive about the name when looking for the jar during initial deployment/upgrade. We just need to make sure we don't look in other jars that might be present (embedded-LABKEY_VERSION.jarorlabkeyBootstrap.jar).Also fixing various problems uncovered by manual testing.
Related Pull Requests
Changes