embedded default cipher update #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
@labkey-mohara Unfortunately we can't set these as defaults that will automatically get applied. It should be part of the template file that we ship in new distributions, but we should specifically recommend that admins use these two properties in the docs if they're enabling HTTPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The default cipher suite is outdated. This updates available cipher suites to match AWS's
ELBSecurityPolicy-TLS13-1-2-2021-06, but is still compatible with at leastELBSecurityPolicy-TLS-1-2-2017-01, and maybe more. This makes it more secure than tomcat's default set.Related Pull Requests
Changes