Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help spread the word on edits to log4j2.xml #816

Merged
merged 4 commits into from
May 8, 2024

Conversation

labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented May 7, 2024

Rationale

There are multiple variants of log4j2.xml for different deployments. When we make a change to the default copy, it may need to be applied elsewhere too.

Changes

  • Encourage collaboration and communication
  • Discourage use of other NotNull and Nullable annotations

@labkey-jeckels labkey-jeckels requested a review from a team May 7, 2024 14:37
@labkey-jeckels labkey-jeckels requested a review from XingY May 7, 2024 19:14
@labkey-jeckels
Copy link
Contributor Author

@XingY inspired by your comment LabKey/platform#5476 (review)

@labkey-jeckels labkey-jeckels merged commit 8e416f4 into develop May 8, 2024
1 of 3 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_log4j2Guidance branch May 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants