Clean up previous embedded installation before extracting upgrade

[labkey-tchad]

Rationale

Issue 50481: Upgrades from 24.3 to 24.4/24.5 need manual cleanup first, otherwise org.labkey.bootstrap.ConfigException

The backup step we used to perform before attempting to self-deploy also served as a method of clearing the way for the new installation. Removing the backup step broke the upgrade process (making the upgrade require manual cleanup of the existing install).

org.labkey.bootstrap.ConfigException: Delete or backup existing LabKey deployment at: /usr/local/labkey/labkey/labkeywebapp
                at org.labkey.embedded.EmbeddedExtractor.extractDistributionZip(EmbeddedExtractor.java:255) ~[!/:24.5.0]
                at org.labkey.embedded.EmbeddedExtractor.extractExecutableJar(EmbeddedExtractor.java:187) ~[!/:24.5.0]
                at org.labkey.embedded.EmbeddedExtractor.extractDistribution(EmbeddedExtractor.java:165) ~[!/:24.5.0]
                at org.labkey.embedded.LabKeyTomcatServletWebServerFactory.getTomcatWebServer(LabKeyTomcatServletWebServerFactory.java:78) ~[!/:24.5.0]

I'm also adding validation of the contents of the distribution.zip to ensure we are backing up everything we should ( currently just the modules and labkeywebapp directories). This check should fail on TeamCity before a change to distribution structure could ever cause problems in the wild.

Related Pull Requests

• Stop copying files into ./backup during embedded startup #775

Changes

• Create a temporary backup while unzipping the LabKey distribution
• Add validation of distribution.zip contents (modules and labkeywebapp)