-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IntelliJ run configurations and service scripts #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know how this lists were determined? The IntelliJ run configurations don't match the embedded install scripts; nor do they match what we specify when starting Tomcat with Gradle.
They seem to match standalone Tomcat, but not quite.
I can't tell you the full history here. These have evolved over time as we've discovered issues or added libraries that require specific flags (like the Snowflake JDBC driver). I'm not surprised that Tomcat's standard list and ours are different. Tomcat has a lot of features that LabKey never uses and LabKey has dependencies that Tomcat doesn't. We should be self consistent, though. Maybe we should try reconciling once we drop standalone Tomcat support and the corresponding startup scripts. |
This change seems fine but I like the followup idea for making them more consistent. @labkey-stuartm @labkey-willm @labkey-jony heads up as I imagine this would need to propagate to cloud deployments when/if someone attempts to adopt Snowflake. That involves adding a new data source to |
@labkey-stuartm @labkey-willm @labkey-jony @labkey-jeckels Snowflake usage will likely be low, and probably non-existent on our cloud deployments for the foreseeable future, but I'd still be in favor of adding this flag everywhere, including all of our startup scripts, service definitions, etc. for consistency. I've added a task to the Snowflake story. |
Java_Reflection_Ops added with this PR LabKey/install-script#72 |
Rationale
Need to add
--add-opens=java.base/java.io=ALL-UNNAMED
flag to JVM startup options for Snowflake