-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Luminex Surveillance results dataset workflow #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed date customization from table customizer class - updated deprecated log helper class in ehr customizer - removed old todo regarding IACUC PI in ehr customizer - added tab page for luminex surveillance results in animal history at Laura P's request - added date customization to query view customization - removed console log from javascript trigger code
RameshRapa
reviewed
Dec 13, 2024
snprc_ehr/src/org/labkey/snprc_ehr/table/SNPRC_EHRCustomizer.java
Outdated
Show resolved
Hide resolved
RameshRapa
approved these changes
Dec 13, 2024
- removed sfp results date column customization (at Marty's request) to determine if the query metadata is working properly on the staging server
jallentxbiomed
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The output from the new Luminex assay is entirely different from the previous assay, with new data types and a new output format. A separate workflow has been created so we can continue to support the old Luminex system while providing support for the new one.