Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a generic build for docker hub, to use with installers of Teamcity #411

Merged
merged 78 commits into from
Oct 27, 2023
Merged

Creating a generic build for docker hub, to use with installers of Teamcity #411

merged 78 commits into from
Oct 27, 2023

Conversation

dnicolalde
Copy link
Collaborator

Rationale

  • Create a generic build process to understand the different fb in teamcity. It also expands the creation of different images for all the services we currently use in production server.
  • Improve docker to use secrets instead of adding passwords to the .env file
  • Restructure the default.env file to make label all variables according to the services they are used
  • Improving and updating use of build.gradle to help using docker commands

Related Pull Requests

  • none

Changes

  • added support for fb and snapshot to the docker build process
  • Now docker can use the fb name to created installers for all the services
  • Migrated to docker compose v2
  • Added secrets to the compose file

dnicolalde added 30 commits April 28, 2023 16:56
@dnicolalde
Making a generic docker build
09626f1
@dnicolalde
Adding some more echo in the build script
2a5a302
@dnicolalde
Adding LabKey version for SNAPSHOT
0676710
@dnicolalde
Remove version num, adding support for develop bch
3b4b249
@dnicolalde
Improving support for develop branch
52c8690
@dnicolalde
adding post_push to send to different repos
4c298a6
@dnicolalde
improving post_push to send image to other repos
068cc60
@dnicolalde
adding support for different Tomcat versions
d693e5b
@dnicolalde
Moving echo closer to delete command
e25ee91
@dnicolalde
Matching Git_Hub_Tag with docker_tag
c5927f7
@dnicolalde
Merge branch 'release22.11-SNAPSHOT' into 22.11_fb_genericBuildScript…
7a81562 
…forDocker
@dnicolalde
Adding logic to docker build script
7c5ebba
@dnicolalde
Merge branch 'release22.11-SNAPSHOT' into 22.11_fb_genericBuildScript…
d6ec9f9 
…forDocker
@dnicolalde
Switching to use Curl
6641500
@dnicolalde
printing teamcity URL
4b692b5
@dnicolalde
Moving variables outside if statement
ec28f68
@dnicolalde
Fixing problem with LK_Version
e3a797f
@dnicolalde
Adding echo to see value of LKVer
39364f0
@dnicolalde
Closing quotes for empty string
c23c8ab
@dnicolalde
Changing number of build hook
09230ba
@dnicolalde
updating build version
d99ed24
@dnicolalde
moving BASH_REMATCH inside if statement
b5c94ae
@dnicolalde
Adding more echos
8b8cc6c
@dnicolalde
increasing build version
0e022c8
@dnicolalde
Moving URL logic to build hook
01b038e
@dnicolalde
Removing echo from build script
6503c4b
@dnicolalde
Updating gradle build to work with docker hooks
ebc16d2
@dnicolalde
updating gradlew and adding version to lk build
2942b6b
@dnicolalde
Merge branch 'release22.11-SNAPSHOT' into 22.11_fb_genericBuildScript…
5f06d64 
…forDocker
@dnicolalde
Adding gradle tasks for docker images and updating build command
d5704ed
@dnicolalde
Copy link
Collaborator Author

@jryurkanin can you have Susan or Trey look at the build.gradle file. Thank you

labkey-tchad
labkey-tchad reviewed Oct 11, 2023
View reviewed changes
docker/build.gradle Show resolved Hide resolved
docker/gradle.properties Outdated Show resolved Hide resolved
csebranek
csebranek reviewed Oct 17, 2023
View reviewed changes
docker/dockerLogin.sh Outdated Show resolved Hide resolved
csebranek
csebranek reviewed Oct 18, 2023
View reviewed changes
docker/labkey/replacingSecrets.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to put the tomcat path in an env var

csebranek
csebranek reviewed Oct 18, 2023
View reviewed changes
docker/postfix/replacingSecrets.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to put the these paths in an env var

@dnicolalde
Copy link
Collaborator Author

I added the postgresql 15 configuration file and ported over some performance change based on https://pgtune.leopard.in.ua/

@dnicolalde dnicolalde merged commit 244f297 into release22.11-SNAPSHOT Oct 27, 2023
@dnicolalde dnicolalde deleted the 22.11_fb_genericBuildScriptforDocker branch October 27, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-tchad labkey-tchad labkey-tchad left review comments

@csebranek csebranek csebranek approved these changes

@jryurkanin jryurkanin Awaiting requested review from jryurkanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnicolalde @csebranek @labkey-tchad @jryurkanin @aschmidt34