Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phonixblocks #1616

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

phonixblocks #1616

wants to merge 5 commits into from

Conversation

WolfPhonix
Copy link

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@WolfPhonix WolfPhonix closed this Jan 12, 2025
@WolfPhonix WolfPhonix reopened this Jan 12, 2025
Copy link
Author

@WolfPhonix WolfPhonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background
background@2x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove file

"color": "#E8B50F",
"versions": "1.21.1<*"
},
"treasure island": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space in key

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of space should be removed? What do you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is currently "treasure island" but it should be "treasureisland"
(JSON naming conventions)

"color": "#E8B50F",
"versions": "1.21.1<*"
},
"treasure island": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is currently "treasure island" but it should be "treasureisland"
(JSON naming conventions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants