Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NinjaMC #723

Closed
wants to merge 35 commits into from
Closed

Add NinjaMC #723

wants to merge 35 commits into from

Conversation

Tamino112
Copy link
Contributor

@Tamino112 Tamino112 commented Oct 2, 2023 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@Tamino112
1
9898006 
Ninjamc
@Tamino112
1
6480ce3 
Updatet background
@Tamino112
3
20f766c 
Updatet Logo and Background
@Tamino112
1
ccc1828
@Tamino112
2
12a1e5b 
delete logo
@Tamino112
Update mainfest.json
27d0317
@Tamino112
1
cd5ebef
@Tamino112
1
67f74af 
Add NInjaMC
DoJapHD
DoJapHD requested changes Oct 31, 2023
View reviewed changes
minecraft_servers/NinjaMC/manifest.json Outdated
"de"
],
"social": {
"Discord": "discord.gg/ninjamc"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON conventions, key has to be lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it now

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invalid url. URL has to start with https:// (social.discord)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invalid url. URL has to start with https:// (social.discord)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invalid url. URL has to start with https:// (social.discord)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

DoJapHD
DoJapHD requested changes Oct 31, 2023
View reviewed changes
minecraft_servers/NinjaMC/manifest.json Outdated
"de"
],
"social": {
"discord": "https://social.dc.ninjamc.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord link has to be https://discord.gg/[YOUR INVITE]
Custom links are for partner servers only

minecraft_servers/NinjaMC/manifest.json Outdated
{
"server_name": "NinjaMC",
"nice_name": "NinjaMC.net",
"direct_ip": "NinjaMC.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IP please in lowercase

minecraft_servers/NinjaMC/manifest.json Outdated
@@ -0,0 +1,19 @@
{
"server_name": "NinjaMC",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server_name please in lowercase (folder name, too!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed it

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Tamino112 Tamino112 closed this Oct 31, 2023
@Tamino112 Tamino112 reopened this Oct 31, 2023
github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/NinjaMC/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/ninjamc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Tamino112 Tamino112 closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD requested changes

@github-actions github-actions[bot] github-actions[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tamino112 @DoJapHD