feat: Added Quick Lyrics Search Activity #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new activity for quick lyrics search that can be launched from an intent. The activity fetches lyrics for a given song and artist using the LyricsProviderService. The user can then send the lyrics back to the calling app. This feature is useful for quickly sharing lyrics without having to open the main app.
Removed custom window insets handling code and system window insets disabling. This simplifies the activity's layout and removes unnecessary code for managing window insets.
Redesigned the Quick Search page UI with new components and structure, enhancing user experience. Added quick access buttons for sending lyrics and navigating to settings. Improved lyrics display with a scrollable and expandable section. Integrated album art using Coil library for improved visual appeal. Added animations for smooth transitions. Updated string resources for better localization. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
- Improved code style and formatting. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
- Added monospace font for timestamps in lyrics to improve readability. - Changed timestamp color to better contrast with the background. - Added song name validation to prevent crashes from invalid intent data. - Improved the UI of the QuickLyricsSearchPage for better clarity and accessibility. - Added content descriptions to icons for improved accessibility. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
- Implemented Material Shared Axis transitions for screen changes, providing a visually appealing and intuitive flow. - Introduced fade-through animations for specific elements, ensuring seamless transitions between states. - Added slide-in animations for vertically arranged content, improving visibility and engagement. - Adjusted animation durations and easing functions for a more polished and natural feel. - Created reusable animation components for better maintainability and consistency across the app. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
Moved the initialization of UserSettingsController to the onCreate method of QuickLyricsSearchActivity due to problems with use of Context before initialization. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
- Introduced shared element transitions for smoother navigation between screens. - Added an error card to display error messages with stack traces. - Updated the UI to use the new error card for error handling. - Updated the language level to JDK 21 and the project JDK to jbr-21. - Added a string resource for unknown errors. - Refactored animation specs for better performance and visual appeal. - Improved the overall user experience by enhancing screen transitions and providing more informative error messages. Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
…ependency (NOT RECOMMENDED) Signed-off-by: Gabriel Fontán <gabilessto@gmail.com>
Lambada10
reviewed
Nov 23, 2024
|
This should be ready to merge, so in case that the changes are accepted, you can go with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new activity for quick lyrics search that can be launched from an intent. The activity fetches lyrics for a given song and artist using the LyricsProviderService. The user can then send the lyrics back to the calling app.
This feature is useful for quickly sharing lyrics without having to open the main app.