Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synced/Unsynced Lyrics Toggle and Refactor Musixmatch API, closes #91 #95

Merged
merged 12 commits into from
Oct 24, 2024

Conversation

kerollosy
Copy link
Contributor

Added a toggle switch component ("Get Synced Lyrics") to allow users to choose between synced and unsynced lyrics from Musixmatch.

Updated the query to separate artist and song name into distinct URL parameters (`artist` and `track`) instead of combining them.
…lyrics data classes

- Added new `SyncedLyricsResponse` and `UnsyncedLyricsResponse` data classes to handle synced and unsynced lyrics separately.
- Updated `MusixmatchSearchResponse` to include nullable `syncedLyrics` and `unsyncedLyrics` fields for more precise handling of lyric types.
- Add syncedMusixmatch property to UserSettingsController
- Update AboutScreen to include SyncedLyricsSwitch component
…r synced and unsynced Musixmatch lyrics retrieval
@Lambada10 Lambada10 merged commit 290dc89 into Lambada10:master Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants