-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto masking tool #46
Conversation
Tool to automatically generate a mask based on the darkest portion of the image. This to skip the manual definition of one and to compensate for possible beam stopper movement (image rotation during acquisition or beam stopper mechanical play).
black formatting check, added to the loading by default and updated tutorials section
Hi Olivier, Very cool, thanks for your contribution. Before I merge, could you:
If you are not used to pip install -r dev-requirements.txt
black . |
Thanks. :) I ran "black" earlier but modified further, now it should be Ok. How do I properly update the current merge request? shall I simply push the changes to my fork? What is a unit test? I ran the pytest as requested:
|
Black formatting
I will add a unit test once I merge the branch then, don't worry about it. For your information, unit tests are small, self-contained tests like this one. |
Thank you for your contribution! I will create a new release today |
Your contribution has been released in version 2.1.17 |
Tool to automatically generate a mask based on the darkest portion of the image. Quite straightforward, to skip the manual definition of a mask, much faster to apply to different DP as it compensates for possible beam stopper movement (image rotation during acquisition or beam stopper mechanical play). In addition. it cuts out much closer to the beam stopper, keeping in valuable information for the autocenter() operation.
CHANGELOG.rst
updated.