Merge pull request #48 from LayerXcom/fix_pep8

Fix pep8

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 120

cbc_casper_simulator/error.py

@@ -19,4 +19,3 @@ def __init__(self, message_hashes: List[int]):
             message_hash) for message_hash in message_hashes]
         reason = " ".join(errors)
         super().__init__(reason)
-

cbc_casper_simulator/message_validator.py

@@ -1,11 +1,15 @@
+from __future__ import annotations
 from result import Ok, Err, Result
-from cbc_casper_simulator.error import *
+# FIXME: Resolve circular reference
+# from cbc_casper_simulator.state import State
+from cbc_casper_simulator.message import Message
+from cbc_casper_simulator.error import Error, MessageNotJustifiedError
 from cbc_casper_simulator.justification import Justification
 
 
 class MessageValidator:
     @classmethod
-    def validate(cls, state: 'State', message: 'Message') -> Result[Error, bool]:
+    def validate(cls, state: 'State', message: Message) -> Result[Error, bool]:
         justified = cls.justification_is_justified(
             state, message.justification)
         if justified.is_err():
@@ -17,7 +21,8 @@ def validate(cls, state: 'State', message: 'Message') -> Result[Error, bool]:
     @classmethod
     def justification_is_justified(cls, state: 'State', justification: Justification) -> Result[Error, bool]:
         not_justified = [h for h in justification.latest_messages.values(
-        ) if not state.store.justified(h)]
+            ) if not state.store.justified(h)]
+
         if len(not_justified) > 0:
             return Err(MessageNotJustifiedError(not_justified))
         else:

cbc_casper_simulator/safety_oracle/clique_oracle.py

@@ -1,5 +1,5 @@
-from result import Ok, Err, Result
-from cbc_casper_simulator.error import *
+from result import Ok, Result
+from cbc_casper_simulator.error import Error
 
 
 class CliqueOracle:

cbc_casper_simulator/state.py

@@ -4,9 +4,9 @@
 from cbc_casper_simulator.message_validator import MessageValidator
 from cbc_casper_simulator.safety_oracle.clique_oracle import CliqueOracle
 from cbc_casper_simulator.util.ticker import Ticker
-from cbc_casper_simulator.error import *
+from cbc_casper_simulator.error import Error
 from typing import Optional
-from result import Ok, Err, Result
+from result import Ok, Result
 
 
 class State:

cbc_casper_simulator/store.py

@@ -2,7 +2,6 @@
 from typing import Dict, List, Optional
 from cbc_casper_simulator.message import Message
 from cbc_casper_simulator.block import Block
-from cbc_casper_simulator.justification import Justification
 from typing import TYPE_CHECKING
 from typing import Union
 if TYPE_CHECKING:

cbc_casper_simulator/validator.py

@@ -3,9 +3,9 @@
 from cbc_casper_simulator.message import Message
 from cbc_casper_simulator.estimator.lmd_ghost_estimator import LMDGhostEstimator as Estimator
 from cbc_casper_simulator.util.ticker import Ticker
-from cbc_casper_simulator.error import *
+from cbc_casper_simulator.error import Error
 import random as r
-from result import Ok, Err, Result
+from result import Result
 
 
 class Validator:

main.py

@@ -1,5 +1,6 @@
-from cbc_casper_simulator.examples.broadcast import simulate as broadcast
-from cbc_casper_simulator.examples.lmd_ghost import simulate as lmd_ghost
+# NOTE: Do not create png files for now
+# from cbc_casper_simulator.examples.broadcast import simulate as broadcast
+# from cbc_casper_simulator.examples.lmd_ghost import simulate as lmd_ghost
 from cbc_casper_simulator.examples.simple import run as simple_run
 import argparse
 

test.sh

@@ -1,5 +1,7 @@
 #!/bin/sh
 
+flake8
+
 pip install -r requirements.txt -r requirements-test.txt
 
 pytest

tests/util/test_ticker.py

@@ -5,4 +5,4 @@ def test_tick():
     ticker = Ticker()
     assert ticker.current() == 0
     ticker.tick()
-    assert ticker.current() == 1
+    assert ticker.current() == 1