Required quorums glitch #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
changed the base branch from
main
to
chore--modify-verifier-to-not-require-eth-archive-node
samlaf
reviewed
Jan 23, 2025
There was a problem hiding this comment.
This approach is fine with me. @gastonponti did you want to try an archive sync using this branch just to double check that it works on your end before we merge it?
Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
samlaf
deleted the branch
Layr-Labs:chore--modify-verifier-to-not-require-eth-archive-node
|
@gastonponti oops I had modified this PR to merge into the archive branch so that reviewing would only show the diff with it. We just merged that PR so this PR was automatically closed. Are you able to reopen this? |
|
I'm not able to reopen it, but I can create a new one |
Merged
|
Created it here: #255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #252
Depends on #241 (merge only after the 241 is part of main)
Changes proposed
As is stated in the issue, it avoids the quorum 1 check for the range of blocks [2950000, 2960000) for Holesky
Note to reviewers
Instead of using a flag passed through the cli, I'm checking the svc address, which will change for the v2, but I'm assuming that this issue will be only for the v1 users.
This check avoids cascading a flag in a lot of places just because of this particular bug. With this approach the custom changes live only in the verifier.