Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract updates #17

Merged
merged 6 commits into from
Aug 13, 2024
Merged

contract updates #17

merged 6 commits into from
Aug 13, 2024

Conversation

0x0aa0
Copy link
Collaborator

@0x0aa0 0x0aa0 commented Aug 7, 2024

No description provided.

@0x0aa0 0x0aa0 marked this pull request as ready for review August 7, 2024 22:55
@0x0aa0 0x0aa0 requested review from epociask and bxue-l2 August 7, 2024 23:14
Comment on lines +6 to +11
contract DummyEigenDABlobVerifier is IRollupManager{

function verifyBlob(
IEigenDAServiceManager.BlobHeader calldata blobHeader,
EigenDARollupUtils.BlobVerificationProof calldata blobVerificationProof
) external view {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could revert the name back to DummyRollupManager. There's a binding for this used in some of the nitro system tests

Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually lets just keep it - updated core nitro accordingly. LGTM

@0x0aa0 0x0aa0 merged commit b2df8e0 into eigenda-v3.0.3 Aug 13, 2024
4 of 9 checks passed
epociask pushed a commit that referenced this pull request Sep 4, 2024
@epociask epociask deleted the arch/contract-updates-v3.0.3 branch September 12, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants