Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convenient script to deploy rollup creator #22

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

hopeyen
Copy link

@hopeyen hopeyen commented Aug 26, 2024

created separate scripts for convenience. We can allow Raas to run the deployCreator.ts script to deploy their own rollup creators

@hopeyen hopeyen requested a review from epociask August 27, 2024 01:22
@hopeyen hopeyen changed the base branch from eigenda-v3.0.3 to eigenda-v3.1.2 September 12, 2024 13:36
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 78 to 89
// This function is called for RollupCreator on L1, where EigenDAServiceManager
// is needed as a constructor argument
// The deployed blob verifier is the EigendaRollupManager argument during rollup creation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a todo identifying that this logic will be deprecated in the future in favor of embedding verifications into the service manager directly

@hopeyen hopeyen merged commit f76aa55 into eigenda-v3.1.2 Sep 13, 2024
4 of 8 checks passed
epociask pushed a commit that referenced this pull request Sep 23, 2024
* feat: scripts for raas

* docs: added todo comment for deprecating blobVerifierL1 in future
epociask pushed a commit that referenced this pull request Sep 30, 2024
* feat: scripts for raas

* docs: added todo comment for deprecating blobVerifierL1 in future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants