fix: Cert timing bug for L2s #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0aa0
approved these changes
Nov 20, 2024
bxue-l2
reviewed
Nov 21, 2024
| @@ -14,6 +18,23 @@ contract EigenDABlobVerifierL1 is IRollupManager { | |||
| IEigenDAServiceManager.BlobHeader calldata blobHeader, | |||
| EigenDARollupUtils.BlobVerificationProof calldata blobVerificationProof | |||
| ) external view { | |||
| /* | |||
| Verify that the certificate is less than 2 epochs old from the L1 reference block number | |||
There was a problem hiding this comment.
2 epoch is about 24mins. In addition, referenceBlockNumber is not right, because it is smaller than confirmationBlockNumber. ReferenceBlockNumber is the number we used to anchor the stake used to distribute chunks to DA nodes. The time diff is the batchingInterval+75(which is some number we introduced to prevent reorg).
There was a problem hiding this comment.
If we stick with confirmationBlockNumber. I think 20 mins is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes