Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565.
The actual fixes here are pretty small, and mostly incidental to action-diffing:
ActionState::pressed
andjust_pressed
were returning true for uninitialized data. Overall, the tests were simply wrong, and expecting bizarre, extremely verbose action-diffs (buttonlike inputs having values, axislike inputs being released...).The tests are substantially simpler now, there's unit tests for action-diffing, all of the action-diffing code lives together, and now there's some nice
set_value
andset_axis_pair
helper methods!