Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep updating disabled actions #583

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Keep updating disabled actions #583

merged 3 commits into from
Aug 8, 2024

Conversation

alice-i-cecile
Copy link
Contributor

/// Actions that are disabled will report as released (but not just released), and their values will be zero.
/// Under the hood, their values are still updated to avoid surprising behavior when re-enabled,
/// but they are not reported to the user using standard methods like [`ActionState::pressed`].
/// To check the underlying values, access their [`ActionData`] directly.

Fixes #575.

@alice-i-cecile alice-i-cecile added the bug Something isn't working label Aug 8, 2024
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) August 8, 2024 15:31
@alice-i-cecile alice-i-cecile merged commit c343479 into main Aug 8, 2024
4 checks passed
@alice-i-cecile alice-i-cecile deleted the better-disabling branch August 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled actions should keep updating anyways to track "pressed but disabled"
1 participant