Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make virtual axial controls more flexible, accepting any kind of Buttonlike #623

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Make virtual axial controls more flexible, accepting any kind of Buttonlike #623

merged 4 commits into from
Oct 6, 2024

Conversation

Shute052
Copy link
Collaborator

@Shute052 Shute052 commented Sep 10, 2024 •
edited by alice-i-cecile
Loading

Fixes #618.

  • made virtual axial controls more flexible, accepting any kind of Buttonlike
    • removed KeyboardVirtualAxis and GamepadVirtualAxis in favor of VirtualAxis
    • removed KeyboardVirtualDPad and GamepadVirtualDPad in favor of VirtualDPad
    • removed KeyboardVirtualDPad3D in favor of VirtualDPad3D

@Shute052 Shute052 added usability Reduce user friction breaking-change A breaking change that requires a new major version labels Sep 10, 2024
alice-i-cecile
alice-i-cecile approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh very nice: that's a much cleaner design.

@alice-i-cecile
Copy link
Contributor

I'd like to hold off on merging this due to the breaking change, but I'm fully on board with this work.

This was referenced Sep 18, 2024
Closed
Closed
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) October 6, 2024 16:00
@alice-i-cecile alice-i-cecile merged commit 2bb436d into Leafwing-Studios:main Oct 6, 2024
4 checks passed
@Shute052 Shute052 deleted the merge-virtual-axis branch October 6, 2024 19:58
@Shute052 Shute052 mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change that requires a new major version usability Reduce user friction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idiomatic way of creating a dpad out of multiple input types
2 participants
@Shute052 @alice-i-cecile