[BUG] Request can be empty (or null)

Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Learnosity · Apr 2, 2024 · d20163e · d20163e
1 parent ae55e19
commit d20163e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Services/PreHashStrings/LegacyPreHashString.php b/src/Services/PreHashStrings/LegacyPreHashString.php
@@ -108,7 +108,7 @@ public function __construct(string $service, bool $v1Compat = false)
 
     public function getPreHashString(
         array $security,
-        array $request,
+        ?array $request,
         ?string $action = 'get',
         ?string $secret = null
     ): string {

diff --git a/src/Services/PreHashStrings/PreHashStringInterface.php b/src/Services/PreHashStrings/PreHashStringInterface.php
@@ -6,12 +6,12 @@ interface PreHashStringInterface
 {
     /* Generate a string ready to be signed
      * @param array $security
-     * @param array $request
+     * @param array|null $request
      * @param string|null $action
      * @param string|null $secret only for legacy pre-hash string generation when $v1Compat is true
      * @return string the pre-hash string
      */
-    public function getPreHashString(array $security, array $request, ?string $action, ?string $secret): string;
+    public function getPreHashString(array $security, ?array $request, ?string $action, ?string $secret): string;
 
     /** Return a list of all supported services
      * @return string[]