Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix finding libcef.so on Linux and other build fixes #58

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

rpaciorek
Copy link

  • use rpath linker option to find libcef.so without setting LD_LIBRARY_PATH
  • generate .gdextension file with correct path (based on build settings)
  • allow run demos with custom value of CEF_ARTIFACTS_FOLDER_NAME without editing demo code

rpaciorek added 4 commits June 1, 2024 09:32
set RPATH to CEF_ARTIFACTS_FOLDER_NAME while build libgdcef.so and gdcefSubProcess
this allow run unmodified demos while using custom value of CEF_ARTIFACTS_BUILD_PATH
this allow use subdirectory as CEF_ARTIFACTS_FOLDER_NAME (like "addons/gdcef")
@Lecrapouille
Copy link
Owner

Nice work 😁 I will check this tonight. Thanks you.

@Lecrapouille Lecrapouille merged commit 601bbf1 into Lecrapouille:godot-4.x Jun 1, 2024
2 checks passed
@Lecrapouille
Copy link
Owner

@rpaciorek merged ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants