Sync master branch to 2.2.4 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgl/flex porting
Fix the txmaker test util
This option allows to compile the testnet app in a mode that allows autoapproving any request, in order to measure the performance of various operations either in speculos, or on a real device.
These tests are no longer worth the maintenance burden, as they test specific conditions and only apply to an old version of the app protocol. The corresponding tests for the newer version of the protocol are kept in the codebase.
It is useful to test that large amounts are shown correctly; instead of generating the psbt synthetically, we hardcode a fixed psbt so we can hardcode the screenshots.
Performance test suite
… using a hardcoded binary
…Nano S; default to 'nanosp' in tests
… transaction flow on flex/stax
Various simplifications in the code to generate the ragger instructions.
…tead of waiting for the timeout
… remaining flows to use 'accounts' instead of 'wallet policy'
Minor adjustments needed in some tests as the page splitting changed.
Refactoring and Stax UX revamp
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| int sign_result = sign_transaction(dc, &st, internal_inputs); | ||
|
|
||
| if (!G_swap_state.called_from_swap) { | ||
| ui_post_processing_confirm_transaction(dc, sign_result); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 84.89% 84.73% -0.17%
==========================================
Files 17 17
Lines 2205 2181 -24
==========================================
- Hits 1872 1848 -24
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b0l0k
reviewed
Jul 17, 2024
b0l0k
reviewed
Jul 17, 2024
b0l0k
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.