Fix signMessage failing for messages of certain lengths
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UX refactoring in version 2.2.2 introduced a bug where signing messages with certain lengths would fail, as the app would ask the client about chunks with an overflowing index.
bigspider
force-pushed
the
fix-signmessage
branch
from
110f2b3
to
23d0ddf
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
========================================
Coverage 84.73% 84.73%
========================================
Files 17 17
Lines 2181 2181
========================================
Hits 1848 1848
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fbeutin-ledger
approved these changes
Aug 6, 2024
lpascal-ledger
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug present since version 2.2.2 makes
signMessagefail for certain message lengths, due to an overflow in the requests to the client in the new UX for arbitrary message lengths.