Always return to main menu at the end of get_wallet_address #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #282 +/- ##
========================================
Coverage 84.76% 84.76%
========================================
Files 17 17
Lines 2186 2186
========================================
Hits 1853 1853
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bigspider
force-pushed
the
processing-glitch
branch
from
fe39141
to
9aa37f7
Compare
bigspider
force-pushed
the
processing-glitch
branch
from
5ac0af2
to
eab72e8
Compare
tdejoigny-ledger
previously approved these changes
Sep 9, 2024
bigspider
force-pushed
the
processing-glitch
branch
from
da86091
to
3a41a7b
Compare
bigspider
force-pushed
the
processing-glitch
branch
from
3a41a7b
to
bb6f2c9
Compare
|
tdejoigny-ledger
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the asynchronous nature of the new UX (which returns the response from a command before the 'status' UX is cleared and its callback is called), some race conditions could be triggered in some situations where the
G_is_timeout_active.processingglobal is not properly managed, possibly not clearing theProcessingscreen, giving the impression that the app is stuck, despite the app correctly returned from previous commands (sending a new command would actually clear it).In version
2.2.4of the app, this happened in particular whenregister_walletfor a relatively complex policy is followed by a silentget_wallet_address(which is indeed common because the client libraries do this automatically).This PR forces to clear the UX after
get_wallet_address; it is likely that other conditions could trigger the same issue, so this is left for a future PR as it requires a rethinking of the state machine managing the UX and theProcessingscreen.Opened a separate issue #283 for a more general solution to the problem.