Sync master to 2.3.0 release. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix sign_psbt_instruction_approve
The UX refactoring in version 2.2.2 introduced a bug where signing messages with certain lengths would fail, as the app would ask the client about chunks with an overflowing index.
Fix `signMessage` failing for messages of certain lengths
…_id during copy_transaction_parameters
Swap release
client_rs: bump bitcoin 0.32 and miniscript 12.2
Performance optimizations
Bump version to 2.3.0; upate CHANGELOG and ragger snapshots
Always return to main menu at the end of get_wallet_address
Update ci action versions
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 84.73% 84.76% +0.03%
==========================================
Files 17 17
Lines 2181 2186 +5
==========================================
+ Hits 1848 1853 +5
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tdejoigny-ledger
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.