Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use ledger device sdk only #37

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Dec 1, 2023

Use only ui crate is now fully merged into ledger_device_sdk

@agrojean-ledger
Copy link
Contributor

@yogh333 you should run cargo fmt on the code, the linting check is KO

Cargo.toml Outdated Show resolved Hide resolved
@agrojean-ledger
Copy link
Contributor

@yogh333 something must have gone wrong in your latest changes in the build.rs script of the SDK following your latest PR : LedgerHQ/ledger-device-rust-sdk#98

The target name field is probably wrongly formatted, we have errors in the CI when trying to run speculos :
https://github.com/LedgerHQ/app-boilerplate-rust/actions/runs/7058052826/job/19212944955?pr=37

@yogh333 yogh333 merged commit 0228594 into LedgerHQ:main Dec 1, 2023
27 checks passed
@yogh333 yogh333 deleted the feat/use_ledger_device_sdk_only branch December 1, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants