Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/test nightly build #43

Closed
wants to merge 2 commits into from
Closed

Feat/test nightly build #43

wants to merge 2 commits into from

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Dec 19, 2023

added github action that will try to build the application everyday using Rust nightly channel

@yogh333 yogh333 requested review from kingofpayne and removed request for xchapron-ledger December 20, 2023 15:25
@agrojean-ledger
Copy link
Contributor

Shouldn't we move this in the SDK and try to build a sample app ?

@yogh333
Copy link
Contributor Author

yogh333 commented Jan 17, 2024

Sample app is not yet available at SDK side and I think that it is perfectly relevant to test new nightly with the boilerplate as it will be used by all other external developers when starting a new app. I think that both building and testing shall be performed so I will update the CI script accordingly.

@agrojean-ledger
Copy link
Contributor

agrojean-ledger commented Jan 17, 2024

Sample app is not yet available at SDK side and I think that it is perfectly relevant to test new nightly with the boilerplate as it will be used by all other external developers when starting a new app. I think that both building and testing shall be performed so I will update the CI script accordingly.

What are the developers supposed to do with this workflow ? Delete it from their app's repo ? It is not something that will be required for deployment... @yogh333

I still think this workflow should be in the SDK : we can do the build with the boilerplate app from there (no need for a sample app then).

@yogh333
Copy link
Contributor Author

yogh333 commented Jan 17, 2024

Ok missed the point that the same workflow could be triggered from SDK repo. Will move it and update it accordingly.

@yogh333 yogh333 closed this Jan 17, 2024
@yogh333 yogh333 deleted the feat/test_nightly_build branch September 30, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants