Add Stax and Flex support #49

agrojean-ledger · 2024-01-18T13:54:03Z

Update the ledger-app-builder docker image and build with cargo ledger build stax (or flex)

… Rust SDK.

used by nbgl api calls.

yogh333

Add few comments to improve readability
LGTM

src/app_ui/address.rs

src/app_ui/menu.rs

src/app_ui/sign.rs

tdejoigny-ledger

--> tests & wordings shall be aligned with the C BP (and the associated guideline)
--> usage.md file shall be updated (add flex target)

README.md

src/app_ui/address.rs

src/app_ui/menu.rs

src/app_ui/sign.rs

tests/test_pubkey_cmd.py

tests/test_sign_cmd.py

agrojean-ledger marked this pull request as draft January 18, 2024 13:54

agrojean-ledger force-pushed the test-stax-build branch from 97569a2 to 4add212 Compare January 18, 2024 16:50

agrojean-ledger force-pushed the test-stax-build branch from 4add212 to b85a864 Compare February 22, 2024 16:27

agrojean-ledger force-pushed the test-stax-build branch from 8119259 to 2210005 Compare March 29, 2024 15:02

agrojean-ledger force-pushed the test-stax-build branch from 8892027 to 7f82152 Compare April 30, 2024 10:28

agrojean-ledger changed the title ~~Add Stax support~~ Add Stax and Flex support May 3, 2024

agrojean-ledger force-pushed the test-stax-build branch from 2e938b9 to 8d492d8 Compare May 20, 2024 09:05

agrojean-ledger marked this pull request as ready for review May 22, 2024 14:47

agrojean-ledger added 10 commits May 23, 2024 15:10

Add Stax support

83e42d3

Small updates for NBGL sync integration.

870a751

Use new include_gif macro to generate NBGL glyphs.

7e319a9

Update code + test snapshots following C string conversion support in…

a977014

… Rust SDK.

Add Flex support.

e74326d

Add settings example.

e4f0c88

Add dashboard icons for Stax and Flex.

dfafdff

Update tests snapshots following version bump in Cargo.toml

10281b3

Use init_comm from nbgl rust module to initialize Comm object reference

98648b3

used by nbgl api calls.

Update test_version test to parse version directly from Cargo.toml

240f7a0

agrojean-ledger force-pushed the test-stax-build branch from 5be39f1 to 240f7a0 Compare May 23, 2024 13:23

agrojean-ledger added 2 commits May 27, 2024 11:45

Update get pub key tests snapshots to show status screens.

5a00f1a

Update cargo.lock

6d6be89

agrojean-ledger force-pushed the test-stax-build branch from 7e42d89 to 6d6be89 Compare May 27, 2024 15:50

agrojean-ledger added 4 commits May 27, 2024 18:07

Fix TOML parsing library import.

cc5c0c8

Fix static analysis.

afd5bb8

Fix icon files bit depth and update tests snapshots.

779deec

Update README

b09dcc1

agrojean-ledger requested review from yogh333 and tdejoigny-ledger May 28, 2024 08:09

yogh333 previously approved these changes May 28, 2024

View reviewed changes

src/app_ui/address.rs Outdated Show resolved Hide resolved

src/app_ui/menu.rs Outdated Show resolved Hide resolved

src/app_ui/sign.rs Outdated Show resolved Hide resolved

tdejoigny-ledger reviewed May 28, 2024

View reviewed changes

PR review.

02b1c32

agrojean-ledger dismissed yogh333’s stale review via 02b1c32 May 28, 2024 15:46

Update usage.md

46a0075

tdejoigny-ledger approved these changes May 29, 2024

View reviewed changes

agrojean-ledger merged commit 2aa6e97 into main May 29, 2024
39 checks passed

agrojean-ledger deleted the test-stax-build branch May 29, 2024 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stax and Flex support #49

Add Stax and Flex support #49

agrojean-ledger commented Jan 18, 2024 •

edited

Loading

yogh333 left a comment

tdejoigny-ledger left a comment

Add Stax and Flex support #49

Add Stax and Flex support #49

Conversation

agrojean-ledger commented Jan 18, 2024 • edited Loading

yogh333 left a comment

Choose a reason for hiding this comment

tdejoigny-ledger left a comment

Choose a reason for hiding this comment

agrojean-ledger commented Jan 18, 2024 •

edited

Loading