Stax

[PolyProgrammist]

Checklist

• App update process has been followed
• Target branch is develop
• Application version has been bumped

[frol]

I reviewed this massive PR and verified that everything works as expected. @dj8yfo has also checked that it works on Nano devices.

@agrojean-ledger Please, review and merge it

[agrojean-ledger]

@PolyProgrammist @frol are you sure you need NbglGenericReview where you are using it ?

The generic review should always be used as a last resort.

Maybe the choice use case would allow you to generate the screens you need ?

It is now available in the latest version of the Rust SDK : 1.13.0

You would be able to add screens like that for instance :

The API allows to add (or not) status text when the user clicks on one of the buttons.

[frol]

are you sure you need NbglGenericReview where you are using it ?

@agrojean-ledger Yes, I am absolutely sure. We use these review screens independently and on the fly while the data is getting streamed on the fly and we don't have the memory to load all the choices upfront.

Thank you for the review, but for god's sake, please, stop doing this "and one more thing". Please, publish this app finally.

[agrojean-ledger]

are you sure you need NbglGenericReview where you are using it ?

@agrojean-ledger Yes, I am absolutely sure. We use these review screens independently and on the fly while the data is getting streamed on the fly and we don't have the memory to load all the choices upfront.

Thank you for the review, but for god's sake, please, stop doing this "and one more thing". Please, publish this app finally.

@frol @PolyProgrammist I suggest you look at the NbglChoice that was just added to the SDK, I think it would be more fitting where you try to use it.

[frol]

I suggest you look at the NbglChoice that was just added to the SDK, I think it would be more fitting where you try to use it.

What is exactly wrong with our implementation from the user perspective that you suggest us to go into refactoring again?

[agrojean-ledger]

I suggest you look at the NbglChoice that was just added to the SDK, I think it would be more fitting where you try to use it.

What is exactly wrong with our implementation from the user perspective that you suggest us to go into refactoring again?

It was just a suggestion. Anyway, I don't understand your code enough to know if you could replace the generic reviews by choice screens.

Bump the version of the package and we'll be done with.

I will merge your PR but the app will only be deployed when it is requested by our product team.

[agrojean-ledger]

@frol @PolyProgrammist The CI is KO, you need to fix it before we can merge.

[PolyProgrammist]

@agrojean-ledger thanks for the review. Could you please rerun CI?

[frol]

@agrojean-ledger Please, approve CI once again

[agrojean-ledger]

@frol @PolyProgrammist There's still one job that fails... you're almost there.