Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating NFC transport in tests #63

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Integrating NFC transport in tests #63

merged 3 commits into from
Nov 25, 2024

Conversation

lpascal-ledger
Copy link
Contributor

@lpascal-ledger lpascal-ledger commented Nov 20, 2024 •
edited
Loading

This PR still needs:

  • the NFC Speculos feature to be merged & deployed
  • fixing the display info bugs & adapting the tests so that the screens are checked
  • checking the "NO NFC" settings disappearance when going to settings and coming back to the home page.
  • more GET_NEXT_ASSERTION tests

@lpascal-ledger lpascal-ledger marked this pull request as draft November 20, 2024 15:11
@lpascal-ledger lpascal-ledger force-pushed the nfc/tests branch 5 times, most recently from f7a0ec8 to 8bc0a7a Compare November 21, 2024 09:10
@lpascal-ledger lpascal-ledger marked this pull request as ready for review November 25, 2024 13:29
@lpascal-ledger
Copy link
Contributor Author

Merging and reporting the missing features into the base branch

@lpascal-ledger lpascal-ledger merged commit 3bba103 into add/getnextassertion Nov 25, 2024
40 checks passed
@lpascal-ledger lpascal-ledger deleted the nfc/tests branch November 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lpascal-ledger