Review

LedgerHQ · Oct 27, 2022 · 0918d87 · 0918d87
1 parent a12689e
commit 0918d87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main.c b/src/main.c
@@ -48,8 +48,10 @@ void handleApdu(volatile unsigned int *flags, volatile unsigned int *tx, int rx)
 
     const int ret = apdu_handle_message(G_io_apdu_buffer, rx, &G_command);
     if (ret != 0) {
+        MEMCLEAR(G_command);
         THROW(ret);
     }
+
     if (G_command.state == ApduStatePayloadInProgress) {
         THROW(ApduReplySuccess);
     }

diff --git a/src/signMessage.c b/src/signMessage.c
@@ -143,8 +143,8 @@ void handle_sign_message_parse_message(volatile unsigned int *tx) {
 
     if ((G_command.non_confirm || G_called_from_swap) &&
         !(G_command.non_confirm && G_called_from_swap)) {
-        // Blind sign requested NOT in swap context
-        // Or no blind sign requested while in swap context
+        // User validation bypass requested NOT in swap context
+        // Or user validation requested while in swap context
         THROW(ApduReplySdkNotSupported);
     }