Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarCloud: Ignore duplication on test files #32

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

SonarCloud: Ignore duplication on test files #32

wants to merge 1 commit into from

Conversation

jibeee
Copy link

@jibeee jibeee commented Jul 1, 2022 •
edited
Loading

Some data in test files is duplicated: parts of raw data transaction are similar between various unit tests.

This triggers SonarCloud duplication detection, while this is a standard practice. I suggest removing duplication detection on unit test code.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jibeee jibeee requested a review from lpascal-ledger July 1, 2022 08:58
@fbeutin-ledger fbeutin-ledger mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

@lpascal-ledger lpascal-ledger Awaiting requested review from lpascal-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jibeee @fbeutin-ledger