Separate UI from parsing before Stax porting #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
9554e1f to
e4aa983
Compare
fbeutin-ledger
force-pushed
the
fbe/more_ragger_tests
branch
from
c7b3a45 to
ea6e72b
Compare
This was referenced Mar 23, 2023
Merged
Closed
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
e4aa983 to
b0bdbf2
Compare
|
It appears (CI failure) snapshots have changed? Was it wanted? Can you fix the CI? |
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
3 times, most recently
from
361a2cf to
7027386
Compare
Should be fixed |
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
7027386 to
cb54087
Compare
|
SonarCloud Quality Gate failed. |
agrojean-ledger
previously approved these changes
Apr 21, 2023
fbeutin-ledger
force-pushed
the
fbe/separate_ui_from_parsing
branch
from
cb54087 to
4d90622
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have finished ported the Solana application for our latest device Ledger Stax
My work is taking place on top of the swap modifications I made
#44
I have separated the new feature in three independant PRs:
Add more Ragger tests for automated non regression testing and Stax screen reproducability
Add more ragger tests #61
Extract the UI code from the logic handling code for the current graphical library BAGL
Separate UI from parsing before Stax porting #62
And finally the Stax porting itself for all screens
Stax porting #59