Skip to content

Commit

Permalink
Merge branch 'master' into paraswap
Browse files Browse the repository at this point in the history
  • Loading branch information
jnicoulaud-ledger authored Oct 10, 2024
2 parents 68d9247 + 02302c5 commit c58721c
Show file tree
Hide file tree
Showing 9 changed files with 59 additions and 16 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
- demo
paths-ignore:
- 'developer-preview/**'

Expand All @@ -25,6 +26,14 @@ jobs:
timeout-minutes: 10
uses: actions/checkout@v4

- name: Get API keys
timeout-minutes: 10
shell: bash
run: |
cat << EOF | jq -r 'to_entries[] | select(.key|endswith("_API_KEY")) | "\(.key)=\(.value)"' >> "$GITHUB_ENV"
${{ toJSON(secrets) }}
EOF
- name: Setup python
timeout-minutes: 10
uses: actions/setup-python@v5
Expand Down
26 changes: 10 additions & 16 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ on:
paths-ignore:
- 'developer-preview/**'

permissions:
id-token: write
contents: read
pull-requests: write

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Expand All @@ -34,6 +29,15 @@ jobs:
registry/**/eip712-*.json
registry/**/calldata-*.json
- name: Get API keys
timeout-minutes: 10
if: steps.changed-descriptor-files.outputs.any_changed == 'true'
shell: bash
run: |
cat << EOF | jq -r 'to_entries[] | select(.key|endswith("_API_KEY")) | "\(.key)=\(.value)"' >> "$GITHUB_ENV"
${{ toJSON(secrets) }}
EOF
- name: Setup python
timeout-minutes: 10
if: steps.changed-descriptor-files.outputs.any_changed == 'true'
Expand All @@ -42,20 +46,10 @@ jobs:
python-version: '3.12'
cache: 'pip'

- name: Login to Ledger JFrog
timeout-minutes: 10
if: steps.changed-descriptor-files.outputs.any_changed == 'true'
uses: LedgerHQ/actions-security/actions/jfrog-login@actions/jfrog-login-1

- name: Setup pip
timeout-minutes: 10
if: steps.changed-descriptor-files.outputs.any_changed == 'true'
run: jf pipc --global --repo-resolve=virtual-pypi-prod-green

- name: Install ERC-7730 library
timeout-minutes: 10
if: steps.changed-descriptor-files.outputs.any_changed == 'true'
run: jf pip install erc7730
run: pip install erc7730

- name: Validate ERC-7730 descriptors changed in pull request
timeout-minutes: 10
Expand Down
4 changes: 4 additions & 0 deletions ercs/eip712-erc2612-permit.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@
"spender",
"value"
],
"excluded": [
"owner",
"nonce"
],
"screens": {}
}
}
Expand Down
4 changes: 4 additions & 0 deletions registry/1inch/eip712-1inch-ethereum.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@
"label": "To",
"format": "raw"
}
],
"excluded": [
"salt",
"makerTraits"
]
}
}
Expand Down
4 changes: 4 additions & 0 deletions registry/1inch/eip712-1inch-polygon-aggregation-router.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@
"label": "To",
"format": "raw"
}
],
"excluded": [
"salt",
"makerTraits"
]
}
}
Expand Down
8 changes: 8 additions & 0 deletions registry/uniswap/eip712-UniswapX-DutchOrder.json
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,14 @@
"encoding": "timestamp"
}
}
],
"excluded": [
"nonce",
"witness.info",
"witness.decayStartTime",
"witness.decayEndTime",
"witness.inputEndAmount",
"witness.outputs.[].startAmount"
]
}
}
Expand Down
10 changes: 10 additions & 0 deletions registry/uniswap/eip712-UniswapX-ExclusiveDutchOrder.json
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@
"encoding": "timestamp"
}
}
],
"excluded": [
"nonce",
"witness.info",
"witness.decayStartTime",
"witness.decayEndTime",
"witness.exclusiveFiller",
"witness.exclusivityOverrideBps",
"witness.inputEndAmount",
"witness.outputs.[].startAmount"
]
}
}
Expand Down
4 changes: 4 additions & 0 deletions registry/uniswap/eip712-UniswapX-LimitOrder.json
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@
"encoding": "timestamp"
}
}
],
"excluded": [
"nonce",
"witness.info"
]
}
}
Expand Down
6 changes: 6 additions & 0 deletions registry/uniswap/eip712-permit2.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@
"spender",
"details.amount"
],
"excluded": [
"sigDeadline"
],
"screens": {}
},

Expand Down Expand Up @@ -183,6 +186,9 @@
"spender",
"details"
],
"excluded": [
"sigDeadline"
],
"screens": {}
}
}
Expand Down

0 comments on commit c58721c

Please sign in to comment.