Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init @ledgerhq/crypto-icons library #3

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mwiercinska
Copy link
Contributor

@mwiercinska mwiercinska commented Aug 5, 2024

First iteration of the @ledgerhq/crypto-icons library.
LIVE-11698
LIVE-11701

Can be tested locally with pnpm-link or by running pnpm i && pnpm build && pnpm pack and then pointing to the package location in a consumer's package.json e.g.
"@ledgerhq/crypto-icons": "file:../crypto-icons/lib/ledgerhq-crypto-icons-1.0.0.tgz"

The following will be in follow-up PRs:

  • Update COINGECKO_MAPPED_ASSETS_URL to prod url
  • Deploying Storybook (+ re-deploy on asset change)
  • Build and publish workflow
  • Additional testing
  • README

add ignore files

add whitespace

test updates and cleanup

ts fix

cleanup

add theme support and styling

rename lib dir

rename lib dir 2

add test workflow

update test workflow

test wf

wf update

test with paths

test with paths 2

test with paths 3

cleanuo

package updates

update test selectors

add IconProvider

feat: init @ledgerhq/crypto-icons library
@mwiercinska mwiercinska marked this pull request as ready for review August 6, 2024 08:23
Copy link

@beths-ledger beths-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! Some small comments. I am going to check it out and test a bit too 👌

lib/src/components/CryptoIcon/CryptoIcon.tsx Show resolved Hide resolved
lib/src/iconMapping.ts Outdated Show resolved Hide resolved
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

lib/tsconfig.json Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Aug 6, 2024

Deploying crypto-icons with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98d4a40
Status: ✅  Deploy successful!
Preview URL: https://a4f90a24.crypto-icons.pages.dev
Branch Preview URL: https://live-11698-create-ledgerhq-c-764m.crypto-icons.pages.dev

View logs

Copy link

@beths-ledger beths-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, can't wait to try out the published version soon!

@mwiercinska mwiercinska merged commit 9ff334f into main Aug 7, 2024
5 checks passed
@mwiercinska mwiercinska deleted the LIVE-11698-create-ledgerhq-crypto-icons-v2 branch August 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants