fix: remove error log #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying crypto-icons-storybook with
|
| Latest commit: |
504d0aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16eb2d39.crypto-icons-storybook.pages.dev |
| Branch Preview URL: | https://fix-remove-error-log.crypto-icons-storybook.pages.dev |
KVNLS
approved these changes
Oct 9, 2024
mwiercinska
force-pushed
the
fix/remove-error-log
branch
from
cff243d
to
892eefa
Compare
Signed-off-by: Monika Wiercinska <monika.wiercinska@yld.io>
Signed-off-by: Monika Wiercinska <monika.wiercinska@yld.io>
mwiercinska
force-pushed
the
fix/remove-error-log
branch
from
892eefa
to
504d0aa
Compare
sarneijim
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
console.erroron failed requests to prevent issues with async logging in consumer Jest tests.Verified this change by adding the packaged lib locally into a project and running tests in the pipeline: https://github.com/LedgerHQ/buy-sell-ui/pull/395