feat: sell feature #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarneijim
reviewed
Aug 20, 2024
sarneijim
reviewed
Aug 20, 2024
lib/src/test.json
Outdated
| @@ -0,0 +1,132 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we remove this file?
sarneijim
reviewed
Aug 20, 2024
package.json
Outdated
Comment on lines
18
to
21
| "dependencies": { | ||
| "@ledgerhq/hw-app-exchange": "0.6.0-nightly.0", | ||
| "protobufjs": "^7.3.2" | ||
| }, |
There was a problem hiding this comment.
yes, the protobuf only
sarneijim
reviewed
Aug 20, 2024
| "devDependencies": { | ||
| "@rollup/plugin-json": "^6.1.0", |
There was a problem hiding this comment.
for now, no, but it's just the rollup json plugin for TS which is good to have in any project, we will definitely need it in the future, it is a dev dependency so it does not bloat the app
sarneijim
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the sell feature work