Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712: fix Uniswap EIP-712 descriptors using unsupported syntax #195

Merged
merged 2 commits into from
Jun 19, 2024
Merged

EIP-712: fix Uniswap EIP-712 descriptors using unsupported syntax #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3971cd0
EIP-712: fix Uniswap EIP-712 descriptors using unsupported syntax
jnicoulaud-ledger Jun 18, 2024
7061825
Merge branch 'main' into BACK-7180-uniswap-fix-unuspported-syntax
jnicoulaud-ledger Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 18 additions & 27 deletions arbitrum/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,16 @@
"path": "witness.inputAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].amount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -270,19 +267,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -445,19 +439,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down
45 changes: 18 additions & 27 deletions arbitrum_sepolia/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,16 @@
"path": "witness.inputAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].amount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -270,19 +267,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -445,19 +439,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down
45 changes: 18 additions & 27 deletions avalanche/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,16 @@
"path": "witness.inputAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].amount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -270,19 +267,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -445,19 +439,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down
45 changes: 18 additions & 27 deletions base/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,16 @@
"path": "witness.inputAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].amount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -270,19 +267,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down Expand Up @@ -445,19 +439,16 @@
"path": "witness.inputStartAmount"
},
{
"format": "token",
"label": "Token to receive",
"path": "witness.outputs[-1].token"
"label": "Tokens to receive",
"path": "witness.outputs.[].tokens"
},
{
"assetPath": "witness.outputs[-1].token",
"format": "amount",
"label": "Receive at Minimum",
"path": "witness.outputs[-1].endAmount"
"label": "Minimum amounts to receive",
"path": "witness.outputs.[].amount"
},
{
"label": "On Address",
"path": "witness.outputs[-1].recipient"
"label": "On Addresses",
"path": "witness.outputs.[].recipient"
},
{
"format": "datetime",
Expand Down
Loading
Loading