Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACK-7356: remove format=token from EIP-712 schemas #196

Merged
merged 3 commits into from
Jun 20, 2024
Merged

BACK-7356: remove format=token from EIP-712 schemas #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2a4703
BACK-7356: remove format=token from EIP-712 schemas
jnicoulaud-ledger Jun 20, 2024
c4499a2
BACK-7356: remove all format=token fields from descriptors
jnicoulaud-ledger Jun 20, 2024
c565504
BACK-7352: Permit EIP-712: switch allowance to `format=amount` (#197)
jnicoulaud-ledger Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions arbitrum/1inch/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,12 @@
"label": "From",
"path": "maker"
},
{
"format": "token",
"label": "Swap Token",
"path": "makerAsset"
},
{
"assetPath": "makerAsset",
"format": "amount",
"label": "Swap Amount",
"path": "makingAmount"
},
{
"format": "token",
"label": "Receive Token",
"path": "takerAsset"
},
{
"assetPath": "takerAsset",
"format": "amount",
Expand Down Expand Up @@ -104,22 +94,12 @@
"label": "From",
"path": "maker"
},
{
"format": "token",
"label": "Swap Token",
"path": "makerAsset"
},
{
"assetPath": "makerAsset",
"format": "amount",
"label": "Swap Amount",
"path": "makingAmount"
},
{
"format": "token",
"label": "Receive Token",
"path": "takerAsset"
},
{
"assetPath": "takerAsset",
"format": "amount",
Expand Down Expand Up @@ -209,22 +189,12 @@
"label": "From",
"path": "maker"
},
{
"format": "token",
"label": "Swap Token",
"path": "makerAsset"
},
{
"assetPath": "makerAsset",
"format": "amount",
"label": "Swap Amount",
"path": "makingAmount"
},
{
"format": "token",
"label": "Receive Token",
"path": "takerAsset"
},
{
"assetPath": "takerAsset",
"format": "amount",
Expand Down
1 change: 0 additions & 1 deletion arbitrum/eip712.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
},
"format": {
"enum": [
"token",
"amount",
"raw",
"datetime"
Expand Down
2 changes: 2 additions & 0 deletions arbitrum/permit/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"path": "spender"
},
{
"format": "amount",
"label": "Allowance",
"path": "value"
},
Expand Down Expand Up @@ -90,6 +91,7 @@
"path": "spender"
},
{
"format": "amount",
"label": "Allowance",
"path": "value"
},
Expand Down
35 changes: 0 additions & 35 deletions arbitrum/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
{
"mapper": {
"fields": [
{
"format": "token",
"label": "Token",
"path": "details.token"
},
{
"assetPath": "details.token",
"format": "amount",
Expand Down Expand Up @@ -88,22 +83,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -244,22 +229,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -416,22 +391,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down
1 change: 0 additions & 1 deletion arbitrum_sepolia/eip712.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
},
"format": {
"enum": [
"token",
"amount",
"raw",
"datetime"
Expand Down
35 changes: 0 additions & 35 deletions arbitrum_sepolia/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
{
"mapper": {
"fields": [
{
"format": "token",
"label": "Token",
"path": "details.token"
},
{
"assetPath": "details.token",
"format": "amount",
Expand Down Expand Up @@ -88,22 +83,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -244,22 +229,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -416,22 +391,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down
1 change: 0 additions & 1 deletion avalanche/eip712.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
},
"format": {
"enum": [
"token",
"amount",
"raw",
"datetime"
Expand Down
2 changes: 2 additions & 0 deletions avalanche/permit/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"path": "spender"
},
{
"format": "amount",
"label": "Allowance",
"path": "value"
},
Expand Down Expand Up @@ -90,6 +91,7 @@
"path": "spender"
},
{
"format": "amount",
"label": "Allowance",
"path": "value"
},
Expand Down
35 changes: 0 additions & 35 deletions avalanche/uniswap/eip712.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
{
"mapper": {
"fields": [
{
"format": "token",
"label": "Token",
"path": "details.token"
},
{
"assetPath": "details.token",
"format": "amount",
Expand Down Expand Up @@ -88,22 +83,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -244,22 +229,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down Expand Up @@ -416,22 +391,12 @@
"label": "Spender",
"path": "spender"
},
{
"format": "token",
"label": "Approve token",
"path": "permitted.token"
},
{
"assetPath": "permitted.token",
"format": "amount",
"label": "Approve amount",
"path": "permitted.amount"
},
{
"format": "token",
"label": "Token to swap",
"path": "witness.inputToken"
},
{
"assetPath": "witness.inputToken",
"format": "amount",
Expand Down
1 change: 0 additions & 1 deletion base/eip712.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
},
"format": {
"enum": [
"token",
"amount",
"raw",
"datetime"
Expand Down
Loading
Loading