feat: expose API for EIP2333 key derivation #110
Conversation
bochaco
force-pushed
the
feat-apis-for-eip2333-key-derivation
branch
3 times, most recently
from
8f06b9a
to
ac1f52f
Compare
| /// Wrapper for 'os_perso_derive_eip2333' | ||
| pub fn eip2333_derive(path: &[u32], key: &mut [u8]) -> Result<(), CxError> { | ||
| unsafe { | ||
| os_perso_derive_eip2333( |
There was a problem hiding this comment.
I know it's what we have done already, but shouldn't we change it to use the no_throw version of the syscalls / cx_calls?
There was a problem hiding this comment.
Yes, I had tried to use os_derive_eip2333_no_throw, but it's not finding it in scope, the same happens with bip32 one, is there a flag/define/env var missing to have these versions exported by https://github.com/LedgerHQ/ledger-secure-sdk or they are just not being exported?
There was a problem hiding this comment.
I'm not sure, they are static inline function defines in os_perso.h @yhql maybe it can't be used to generate bindings?
ledger_device_sdk/src/ecc.rs
Outdated
| @@ -495,6 +508,19 @@ impl SeedDerive for Stark256 { | |||
| } | |||
| } | |||
|
|
|||
| impl SeedDerive for Bls12381G1 { | |||
| type Target = ECPrivateKey<32, 'E'>; | |||
There was a problem hiding this comment.
Bls12381G1 is a Weierstrass curve, so should be ECPrivateKey<32, 'W'> ideally
ledger_device_sdk/src/ecc.rs
Outdated
| @@ -530,6 +556,7 @@ impl_curve!(BrainpoolP512R1, 64, 'W'); | |||
| impl_curve!(BrainpoolP512T1, 64, 'W'); | |||
| impl_curve!(Stark256, 32, 'W'); | |||
| impl_curve!(Ed25519, 32, 'E'); | |||
| impl_curve!(Bls12381G1, 32, 'E'); // TODO: review type of curve (...and sigining impl) | |||
There was a problem hiding this comment.
I guess we should not do this and expose the usual signing APIs yet. EdDSA or ECDSA are typically not used on BLS12381G1. We need to find a way to expose signing on BLS12381G2 though, which is a BLS signature, not ECDSA or EdDSA, and whose keys must be derived with eip2333 using G1
There was a problem hiding this comment.
Agreed, apart from impl. details w.r.t. being able to use the impl_curve! or not that I'll try to work out, I've found there is ox_bls12381_sign, is that supposed to be good enough for BLS12381G2 sig?
bochaco
force-pushed
the
feat-apis-for-eip2333-key-derivation
branch
5 times, most recently
from
fa2250a
to
026d5a8
Compare
bochaco
force-pushed
the
feat-apis-for-eip2333-key-derivation
branch
from
026d5a8
to
48a7ceb
Compare
|
Could we rename this PR into "BLS12-381 support" ? |
No description provided.