add workflow to build all Rust apps for every PR #125
Conversation
yogh333
force-pushed
the
jca/build_all_apps
branch
from
335545d
to
6e2ce74
Compare
yogh333
force-pushed
the
jca/build_all_apps
branch
2 times, most recently
from
dd0e3d4
to
4b3cdf0
Compare
.github/workflows/build_all_apps.yml
Outdated
| matrix: | ||
| include: | ||
| - repo: 'app-mobilecoin' | ||
| branch: 'develop' |
There was a problem hiding this comment.
Can we use the default branch instead? Though this might be less clear...
There was a problem hiding this comment.
Agreed. Shall wait develop branch to be merged into main/master in that case.
yogh333
force-pushed
the
jca/build_all_apps
branch
from
c3a817b
to
3224ad1
Compare
.github/workflows/build_all_apps.yml
Outdated
| include: | ||
| #- repo: 'app-mobilecoin' | ||
| # branch: 'develop' | ||
| - repo: 'app-radix-babylon' | ||
| branch: 'develop' | ||
| - repo: 'app-boilerplate-rust' | ||
| branch: 'main' | ||
|
|
There was a problem hiding this comment.
Could be good to not have an hardcoded list but to build dynamically the list.
I tried to do that in this PR for C app (name: Get C apps repos)
There was a problem hiding this comment.
As we need a way to retrieve all apps in multiples places:
- Rust SDK CI
- C SDK CI
- app tester?
Maybe it could be moved to ledgered?
There was a problem hiding this comment.
I agree, I will update the workflow accordingly when the feature will be provided by ledgered. in the meantime, we should proceed with this manual listing as it fulfils the requirement (build all Rust apps with the PR-modified Rust SDK to check if any regression).
There was a problem hiding this comment.
If no one adds it to ledgered it's never going to be there ;)
There was a problem hiding this comment.
lucas will do when he will have the bandwidth
yogh333
force-pushed
the
jca/build_all_apps
branch
from
43c7769
to
102a7a0
Compare
No description provided.