Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update include_gif macro so it can accept any kind of image as input. #174

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Jul 30, 2024

JIRA ISSUE : https://ledgerhq.atlassian.net/jira/software/c/projects/EMBSDK/boards/818?selectedIssue=EMBSDK-52

  • Accept different file formats (GIF, PNG, JPG...). Still need to be careful with compressed file formats as they introduce some visual artifacts that can alter the final result (better to stick with uncompressed like GIF, PNG).
  • No need to have gray scale images as input, color images can be used. Conversion is automatic :
    • To 1-bit depth (1 color) black and white for Nano devices,
    • Up to 4-bit depth (16 colors) gray scale for Stax / Flex.

⚠️ Care should still be taken regarding the size of the images as they are not resized automatically by the macro to each device's screen requirements.

  • Run tests of rust boilerplate to check if the include_gif output is 100% unchanged.

@agrojean-ledger agrojean-ledger merged commit e1941b8 into master Jul 30, 2024
43 checks passed
@agrojean-ledger agrojean-ledger deleted the update-include-gif branch July 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants