feat: add missing app os flags for appInfo instruction #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
force-pushed
the
feat/zondax
branch
from
dadcff9
to
bc24843
Compare
|
Thank you, we use this in our ledger rust app, and the crash from trying to read past the end of the buffer because flags are not sent is causing our app some problems. We really appreciate this and look forward to getting this merged. @ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the C SDK, the appInfo instruction has the appFlags available. On the Rust bindings, that is missing. That makes the same command for two different apps incompatible. I tested it locally, and it is possible to add it. I am not aware of reasons why it was missing. I suppose it was forgotten.
Thanks!